Fix JVPs for Float *= and /=
#33579
Merged
Fix JVPs for Float *= and /=
#33579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, JVP/VJP generation used a "return undef" hack when differential/pullback values did not match the expected return type. This was relevant before differentiation supported "loadable types with address-only tangent types", which was diagnosed. Now that support for the above exists, "return undef" should be removed and replaced with an assertion.
JVPs for `*=` and `/=` were specified incorrectly.
efremale
force-pushed
the
fix-float-jvps
branch
from
cc5bd12 to
aafaf4e
Compare
|
@swift-ci Please test |
|
@dan-zheng, I still don't have the access to trigger the CI, can you please do it? |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
rxwei
approved these changes
Aug 21, 2020
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JVPs for
*=and/=were specified incorrectly.