-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[master-rebranch] Merge in master and fix missing include in Decl.cpp #33594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nathawes
merged 16 commits into
swiftlang:master-rebranch
from
nathawes:fix-missing-include
Aug 22, 2020
Merged
[master-rebranch] Merge in master and fix missing include in Decl.cpp #33594
nathawes
merged 16 commits into
swiftlang:master-rebranch
from
nathawes:fix-missing-include
Aug 22, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When @compatibility_alias is used with an ObjC generic class, this ends up importing as a generic typealias. PrintAsObjC previously didn’t handle declarations involving these types correctly; it would fail an assertion in asserts compilers, and potentially print an incorrect compatibility header in non-asserts compilers. This PR makes it so that PrintAsObjC can now correctly use generic typealiases imported from Objective-C modules. It is, of course, still not possible to declare a generic typealias in Swift that will be printed into the Objective-C header. Fixes rdar://67256866.
…ns"" This reverts commit bf25a01.
Codable's magic previously relied on the subject of every qualified lookup in an unqualified lookup stack to force the synthesis of this member. This allowed users to reference CodingKeys transitively through a non-primary input without qualification. As part of the requestification of name lookup, this synthesis was moved out of the normal qualified lookup path and into the Type Checker's semantic lookup entrypoints in order to prevent wild cycles caused by protocol conformance resolution. In the process, we forget to restore the synthesis check at this entrypoint. To patch up the source break this caused, we need to walk the context stack again and force synthesis. Unfortunately, we're stuck with a hack like this until we bring Codable's implementation back out of the realm of magic once more. A future implementation of synthesizeSemanticMembersIfNeeded should aim to just craft the AST for CodingKeys, but not actually run any of the semantic checks until we check the conformance to CodingKey. rdar://65088901, SR-13137
…sing specified additional arguments To help solving rdar://67079780, this change allows swift-driver to configure scanner using additional arguments passed down via the batch input JSON file for each module under scanning.
…-electric-boogaloo Support generic @compatibility_alias in PrintAsObjC
…le-take-2 [Serialization] Serialize isUserAccessible on functions - Take 2
…input DependenciesScanner: teach batch scanning mode to configure scanner using specified additional arguments
…cess Patch A Regression in Lookup for CodingKeys
…out` parameters (swiftlang#33584) Adds forward mode support for `apply` instruction with `inout` arguments. Example of supported code: ``` func add(_ x: inout Float, _ y: inout Float) -> Float { var result = x result += y return result } print(differential(at: 1, 1, in: add)(1, 1)) // prints "2" ```
Fix total bit count for Decl and AbstractFunctionDecl bitfields.
@swift-ci please smoke test |
@swift-ci clean smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.