[ownership] When computing usesNotContainedWithinLifetime make sure the error is only a use not in lifetime error.

[gottesmm]

Otherwise, we can return true in cases where we do not have a proper linear
lifetime which can occur in the presence of destructures.

rdar://problem/67698939

[gottesmm]

Eventually I may want to have some sort of enum here. Makes me nervous doing these sorts of exhaustive checks. But this code doesn't change too much so I think it is ok for now.

[atrick]

FWIW, I find it easier to think about APIs that don't involve double-negative. i.e. is should be '!usesContainded', not 'usesNotContained'

[gottesmm]

Ok. I am fine with changing that.

[gottesmm]

I am going to invert that in a follow on commit.

[gottesmm]

@swift-ci test

[gottesmm]

@swift-ci test source compatibility

[gottesmm]

@swift-ci benchmark

[swift-ci]

Performance: -O

Improvement	OLD	NEW	DELTA	RATIO
FlattenListLoop	2471	1632	-34.0%	1.51x (?)
FlattenListFlatMap	5071	4500	-11.3%	1.13x (?)
ObjectiveCBridgeStubFromNSString	876	807	-7.9%	1.09x (?)

Code size: -O

Performance: -Osize

Code size: -Osize

Performance: -Onone

Regression	OLD	NEW	DELTA	RATIO
String.data.Medium	115	129	+12.2%	0.89x (?)
String.data.LargeUnicode	124	139	+12.1%	0.89x (?)

Code size: -swiftlibs

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB