Skip to content

[ConstraintSystem] Extend invalid function body fix to cover constraint generation failures #33762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Sep 2, 2020

Ignore function builder body if it emits at least one diagnostic
during constraint generation.

Resolves: rdar://problem/65983237

@xedin xedin requested review from DougGregor and hborla September 2, 2020 18:20
@xedin
Copy link
Contributor Author

xedin commented Sep 2, 2020

@swift-ci please smoke test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great solution, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants