SIL: fix some memory leaks and add verification for leaked instructions #33888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
force-pushed
the
fix-leaks
branch
from
14cd172 to
d26d7b6
Compare
|
@swift-ci test |
|
Build failed |
|
Build failed |
eeckstein
force-pushed
the
fix-leaks
branch
from
d26d7b6 to
6894a08
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Build failed |
|
Build failed |
The leak happened in this scenario: 1. A function becomes dead and gets deleted (which means: it gets added to the zombie-list) 2. A function with the same name is created again. This can happen with specializations. In such a case we just removed the zombie function from the zombie-list without deleting it. But we cannot delete zombie functions, because they might still be referenced by metadata, like debug-info. Therefore the right fix is to resurrect the zombie function if a new function is created with the same name. rdar://problem/66931238
… SILModule. It's not needed because the names are stored in the ZombieFunctionTable anyway (this table was added later).
This fixes a memory leak: instructions of the static initializer block were not be freed. rdar://problem/66931238
* Leaks due to forwarding values * Leaks due to abort on errors rdar://problem/66931238
All instructions after an "unreachable" were not added to the function anyway and were leaking.
…option It had no effect, because such SIL is never generated anyway.
…odule destructor.
eeckstein
force-pushed
the
fix-leaks
branch
from
6894a08 to
56c857a
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some memory leaks:
1. related to zombie functions
The leak happened in this scenario:
In such a case we just removed the zombie function from the zombie-list without deleting it.
But we cannot delete zombie functions, because they might still be referenced by metadata, like debug-info.
Therefore the right fix is to resurrect the zombie function if a new function is created with the same name.
2. Let SILGlobalVariables be destroyed
Instructions of the static initializer block were not be freed.
3. Leaks in SILParser
Also: check for leaked instructions in the SILVerifier and in the SILModule destructor.
rdar://problem/66931238