[build-script] Disable pkg-config for Darwin hosts (NFC) #33939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable
pkg-config
on Darwin to prevent compilation issues.This is an NFC follow up to #32436 and #32437.
The benefits are:
pkg-config
issues directly, instead of a roundabout wayFor 1, the original issue was that CMake
find_
functions would searchpkg-config
before the SDK. Homebrewpkg-config
hardcodes CommandLineTools, even when Xcode is installed, and this caused problems. See SR-12726.Disabling
pkg-config
gives better isolation, and it removes the use ofCMAKE_PREFIX_PATH
which I see as a bigger hammer than disablingpkg-config
.Before any of these changes, if
pkg-config
is installed, the effective search order was:CMAKE_PREFIX_PATH
(empty)HINTS
paths (CommandLineTools viapkg-config
)After #32436, the relevant search order became:
CMAKE_PREFIX_PATH
(SDK)HINTS
paths (CommandLineTools viapkg-config
)Now with this change, the relevant search order is:
CMAKE_PREFIX_PATH
(empty)HINTS
paths (empty)