[CSGen] Avoid failing on invalid declarations #34036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Associating holes directly with declarations is useful in cases when declarations are invalid e.g. directly `ErrorType` or have error types inside.
… for code completion
Solver needs to handle invalid declarations but only in "code completion" mode since declaration in question might not be associated with code completion, otherwise (if constraint generation fails) there is going to be no completion results.
nathawes
approved these changes
Sep 23, 2020
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows platform |
hborla
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solver needs to handle invalid declarations but only in
"code completion" mode since declaration in question might
not be associated with code completion, otherwise (if constraint
generation fails) there is going to be no completion results.
In order to make this work we need to:
HoleTypeto allow it to be originated fromVarDecl;VarDecltypes which respects constraint system flagsand can convert any
ErrorTypesintoHoleTypess.