[5.3][CSGen] Check whether parent has a contextual type before diagnosing nil use
#34060
+38
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`nil` use
Before considering `nil` to be used without a context, let's
check whether parent expression (semantic significance of
which is not important) has a contextual type associated with it,
otherwise it's possible to misdiagnose cases like:
```swift
func test() -> Int? {
return (nil)
}
```
(cherry picked from commit 90e6fd4)
|
@swift-ci please test |
DougGregor
approved these changes
Sep 24, 2020
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #34046
Before considering
nilto be used without a context, let'scheck whether parent expression (semantic significance of
which is not important) has a contextual type associated with it,
otherwise it's possible to misdiagnose cases like:
Scope: Limited to
nilliterals wrapped into parens or other non-semantic expressions e.g.await,tryusedreturnstatements.Resolves: rdar://problem/69454410
Risk: Low
Testing: Added regression tests
Reviewer: @hborla, @CodaFi
Resolves: rdar://problem/69454410
(cherry picked from commit 90e6fd4)