Target sdk aliases and exclusions #3411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @gribozavr |
| @@ -3,3 +3,12 @@ function(precondition var) | |||
| message(FATAL_ERROR "Error! Variable ${var} is false or not set!") | |||
| endif() | |||
| endfunction() | |||
|
|
|||
| macro(list_replace lst old new) | |||
There was a problem hiding this comment.
We are trying really hard to use functions when possible. Could you change this into a function? You can use PARENT_SCOPE to set the variable in the caller.
There was a problem hiding this comment.
Yeah, I agree, functions are better as they don't pollute the global namespace. Ill see if I can get that changed.
|
@swift-ci Please test |
|
Introduce two new aliasees `ALL_POSIX_PLATFORMS` and `ALL_APPLE_PLATFORMS`. The latter expands to iOS, tvOS, watchOS, macOS and if relevant, the simulators. The former expands to the same list as `ALL_APPLE_PLATFORMS` as well as Linux and FreeBSD.
pthreads is not available on non-POSIX platforms (i.e. Windows). Restrict the target platforms that we build SwiftPrivatePthreadExtras and things which depend on it.
compnerd
force-pushed
the
target-sdk-aliases-and-exclusions
branch
from
eb18cb3 to
65fd24d
Compare
|
@swift-ci Please test |
|
@gribozavr okay to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.