Skip to content

Add a test that checks that ClangImporter chooses only exported modules #34392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

Add a test that checks that ClangImporter chooses only exported modules #34392

merged 1 commit into from
Oct 23, 2020

Conversation

scentini
Copy link
Contributor

This test checks that when ClangImporter qualifies types with a module name, we choose a visible module.
This is a test for SR-13032, taken from PR #32465.

@scentini
Copy link
Contributor Author

@swift-ci please test

@scentini scentini requested a review from hlopko October 22, 2020 09:57
@scentini scentini added the c++ interop Feature: Interoperability with C++ label Oct 22, 2020
@scentini scentini merged commit 9f8b966 into swiftlang:main Oct 23, 2020
@scentini scentini deleted the stdlib branch October 23, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hlopko hlopko hlopko approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scentini @hlopko