[cxx-interop] Support reference types in function templates. #34536
Conversation
lib/ClangImporter/ImportType.cpp
Outdated
| if (auto *templateParamType = | ||
| dyn_cast<clang::TemplateTypeParmType>(paramTy)) { | ||
|
|
||
| if (isa<clang::ReferenceType>(paramTy) && |
There was a problem hiding this comment.
Nit: use if (auto referenceType = dyn_cast<...>? for both referenceType and for templateParamType? I think it will make the body more readable at the price of increased indent.
There was a problem hiding this comment.
The only issue is then the else if doesn't work. I could introduce a variable isReferenceWrappedTempalte but that basically has the same issue as the current if statement. Happy to do that if you'd rather, though.
There was a problem hiding this comment.
I've replaced the calls to isa<clang::ReferenceType> and cast<clang::ReferenceType> with a dyn_cast<clang::ReferenceType> at the top of the if. Let me know what you think.
There was a problem hiding this comment.
Ah I see, yeah then it cannot be super clean anyway. The code we how now LGTM. Thanks!
zoecarver
force-pushed
the
cxx/fix/reference-wrapped-templates
branch
from
8cd8347 to
c6aef37
Compare
|
@swift-ci please smoke test. |
* 'main' of github.com:apple/swift: [cxx-interop] Don't crash for unkown inline-operator. (swiftlang#34602) [cxx-interop] Support reference types in function templates. (swiftlang#34536)
Support reference wrapped template params such as: