Skip to content

[value-lifetime] Cleanup constructors. #34755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

No description provided.

@gottesmm gottesmm requested review from atrick and meg-gupta November 16, 2020 00:56
@gottesmm
Copy link
Contributor Author

Not much here... just no crazy template stuff.

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci test windows platform

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

@gottesmm
Copy link
Contributor Author

The key thing to notice here is that this API actually stores these uses in side of itself. So the actual type on the outside doesn't matter. What this patch does is make it so that one can pass a range of SILInstruction or a use iterator so one can also do SILValue::getUses() to seed the ValueLifetimeAnalysis.cpp. It is really nice for avoiding unnecessary container friction around SILInstruction, Operand trafficking.

1 similar comment
@gottesmm
Copy link
Contributor Author

The key thing to notice here is that this API actually stores these uses in side of itself. So the actual type on the outside doesn't matter. What this patch does is make it so that one can pass a range of SILInstruction or a use iterator so one can also do SILValue::getUses() to seed the ValueLifetimeAnalysis.cpp. It is really nice for avoiding unnecessary container friction around SILInstruction, Operand trafficking.

@gottesmm gottesmm merged commit b78a649 into swiftlang:main Nov 16, 2020
@gottesmm gottesmm deleted the pr-c948d27bcce9be4feb87ece1fc46b74931415542 branch November 16, 2020 11:26
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants