[concurrency] implement lowering of implicitly async calls #34917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
force-pushed
the
implicitly-async-silgen
branch
from
5b78192 to
3c6d27e
Compare
implicitly-async calls are calls to synchronous actor-isolated functions. Synchronous functions cannot perform hop_to_executor, so implicitly async calls have the convention that the caller is responsible for switching to the right executor prior to entering the actor-isolated callee. It follows naturally that the caller must then switch back to the appropriate executor after the implicitly-async call completed. Now, if the caller is not isolated to a _specific_ actor, then we are (currently) _not_ emitting a hop to go back to the caller's executor, because that caller's executor is unspecified (and currently not accessable in SIL). This behavior may change in the future; tracked in rdar://71905765
kavon
force-pushed
the
implicitly-async-silgen
branch
from
3c6d27e to
60fa93f
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a call is to a synchronous function that is isolated to a different actor, then the call is treated as implicitly async. An earlier PR #34678 implemented the first part of this, which is to mark such calls in the AST as being implicitly async. This PR finishes the implementation by lowering / expanding that annotation during SILGen.
Resolves rdar://71606265