Skip to content

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Dec 4, 2020

I reimplemented the original addNewEdgeValueToBranch to just call the new
overload with a default InstModCallbacks, so nothing changed and now we can plug
in callbacks to this utility!

@gottesmm gottesmm requested review from atrick and meg-gupta December 4, 2020 07:04
@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 4, 2020

@swift-ci smoke test

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gottesmm gottesmm force-pushed the pr-98cbb22de5b33dbf86eecf90b5c5adcda4a81c8d branch from e0604e6 to fb693f8 Compare December 4, 2020 08:03
@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 4, 2020

@swift-ci smoke test

…s an InstModCallback.

I reimplemented the original addNewEdgeValueToBranch to just call the new
overload with a default InstModCallbacks, so nothing changed and now we can plug
in callbacks to this utility!
@gottesmm gottesmm force-pushed the pr-98cbb22de5b33dbf86eecf90b5c5adcda4a81c8d branch from fb693f8 to 16b63b1 Compare December 4, 2020 09:07
@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 4, 2020

@swift-ci smoke test

1 similar comment
@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 4, 2020

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 4, 2020

@swift-ci smoke test linux platform

1 similar comment
@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 4, 2020

@swift-ci smoke test linux platform

@gottesmm gottesmm merged commit 8914ba6 into swiftlang:main Dec 4, 2020
@gottesmm gottesmm deleted the pr-98cbb22de5b33dbf86eecf90b5c5adcda4a81c8d branch December 4, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants