[cxx-interop] Support scoped enums (enum classes). #34974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test. |
hlopko
reviewed
Dec 16, 2020
hlopko
approved these changes
Dec 16, 2020
zoecarver
force-pushed
the
cxx/enums-are-enums
branch
from
8e03779 to
6cb0ffb
Compare
|
@swift-ci please smoke test. |
zoecarver
force-pushed
the
cxx/enums-are-enums
branch
from
6cb0ffb to
e866a2e
Compare
|
@swift-ci please smoke test. |
|
@swift-ci please smoke test OS X platform. |
|
@swift-ci please test Windows. |
|
@swift-ci please smoke test OS X platform. |
|
@swift-ci please test Windows. |
Simply treat scoped enums as (pre-existing) "non frozen enums". C++ scoped enums are actually imported as Swift enums (unlike other enums) and no global variables need be created (given their "scoped" nature).
zoecarver
force-pushed
the
cxx/enums-are-enums
branch
from
e866a2e to
3c5f2c9
Compare
|
@swift-ci please smoke test. |
|
@swift-ci please smoke test Linux. |
1 similar comment
|
@swift-ci please smoke test Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply treat scoped enums as (pre-existing) "non-frozen enums". C++ scoped enums are actually imported as Swift enums (unlike other enums) and no global variables need to be created (given their "scoped" nature).
I'd really like to import all enums as Swift enums, but the ship may have sailed on that one for C, at least. Stay tuned for future patches...