[IRGen] Corrected mangling of AsyncFunctionPointers. #35103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please clean test windows platform |
|
Build failed |
|
Build failed |
nate-chandler
force-pushed
the
concurrency/irgen/rdar72336407
branch
from
e205bde to
c5ef541
Compare
Previously, the suffix "AD" was used to mangle AsyncFunctionPointers. That was incorrect because it was already used in the mangling scheme. Here, that error is fixed by using 'u' under the thunk or specialization operator 'T' to mangle AsyncFunctionPointers. Additionally, printing and demangling support is added. rdar://problem/72336407
nate-chandler
force-pushed
the
concurrency/irgen/rdar72336407
branch
from
c5ef541 to
73cfca8
Compare
|
@swift-ci please test |
|
Im very confused. This change seems to have caused a Windows regression: https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/3752/ However, the CI here passed on Windows? Could you please take a look @nate-chandler? |
|
Awesome, thanks @nate-chandler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the suffix "AD" was used to mangle AsyncFunctionPointers. That was incorrect because it was already used in the mangling scheme. Here, that error is fixed by using 'u' under the thunk or specialization operator 'T' to mangle AsyncFunctionPointers. Additionally, printing and demangling support is added.
rdar://problem/72336407