Skip to content

[Sema] Accept availability macros in @_originallyDefinedIn #35413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Jan 13, 2021

Availability macros passed via the frontend flag -define-availability should be accepted by @_originallyDefinedIn where they behave as they do in @available.

rdar://72354787

xymus added 2 commits January 13, 2021 10:42
The compiler will print the attributes on their own lines as we tend to
write them in the tests. It should make the attributes more easily readable
in the generated swiftinterfaces and such.
Availability macros passed via the frontend flag -define-availability
should be accepted by @_originallyDefinedIn where they behave as they do
in @available.

rdar://72354787
@xymus xymus requested a review from nkcsgexi January 13, 2021 18:54
@xymus
Copy link
Contributor Author

xymus commented Jan 13, 2021

@swift-ci Please smoke test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thank you for handling this.

@xymus xymus merged commit be7462e into swiftlang:main Jan 13, 2021
@xymus xymus deleted the originally-defined-in-macro branch January 13, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants