Pass -target to lit Tests instead of -arch (+ -version-min) #35435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow-on to b436825 where -m${platform}-version-min was traded for -target. The lit substitution for %target-clang was relying on -arch and -version-min to specify the intended platform version to the linker. With the removal of version-min, only arch was given, so a fallback platform was selected. For the iPhone simulator, for example, this is iOS 10.99 despite there being no such simulator for that deployment version. Provide the variant triple everywhere instead. This has the added benefit of unifying the special paths catalyst takes. Fixes rdar://73174820
|
@swift-ci test |
|
preset=buildbot_all_platforms,tools=RA,stdlib=RA |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-on to
b4368259480ed2c895e8c855bbfde20c1805acd1where-m${platform}-version-min was traded for -target. The lit substitution
for %target-clang was relying on -arch and -version-min to specify the
intended platform version to the linker. With the removal of
version-min, only arch was given, so a fallback platform was selected.
For the iPhone simulator, for example, this is iOS 10.99 despite there
being no such simulator for that deployment version. Provide the variant
triple everywhere instead. This has the added benefit of unifying the
special paths catalyst takes.
Fixes rdar://73174820