[test] Mark concurrency tests with appropiate REQUIRES. #35624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python build system always enables concurrency, but CMake has it disable by default. Collaborators that do not use the Python build system and use directly CMake will have it disable, unless they explicitely enable it. If the tests are not marked as requiring the concurrency features, the tests will fail to execute when concurrency is disabled. The changes add the `REQUIRES: concurrency` line to many tests that deal with concurrency, but wasn't marked as such.
|
@swift-ci please test |
|
@swift-ci please test Windows platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python build system always enables concurrency, but CMake has it
disable by default. Collaborators that do not use the Python build
system and use directly CMake will have it disable, unless they
explicitely enable it. If the tests are not marked as requiring the
concurrency features, the tests will fail to execute when concurrency is
disabled.
The changes add the
REQUIRES: concurrencyline to many tests that dealwith concurrency, but wasn't marked as such.
The tests were found using the following:
grep -L -e 'REQUIRES: concurrency' $(grep -r -l -e 'enable-experimental-concurrency' validation-test/ test/).This is a more complete version of #35557 (with a proper explanation).