[Build] Add option to alter default location of module cache in Linux #35711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to support parallel CI runs on the same Linux bot, so that they don't share the module cache and reduce (hopefully) the likelihood of issues related to invalid signatures. When the option is enabled, the environment variable `XDG_CACHE_HOME` is explicitly set in `build-script` and should be inherited by all the child processes. Currently we don't check the operating system before setting the variable (since it should be a noop for other OSes). Addresses rdar://73887745
|
@swift-ci please python lint |
|
@swift-ci please smoke test |
compnerd
approved these changes
Feb 2, 2021
shahmishal
approved these changes
Feb 2, 2021
|
Sure -- I was planning to do that as a separate step (to both catch unanticipated fallout and have a bit of control over the "rollout" of this flag) |
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Feb 19, 2021
…swiftlang#35711) This is meant to support parallel CI runs on the same Linux bot, so that they don't share the module cache and reduce (hopefully) the likelihood of issues related to invalid signatures. When the option is enabled, the environment variable `XDG_CACHE_HOME` is explicitly set in `build-script` and should be inherited by all the child processes. Currently we don't check the operating system before setting the variable (since it should be a noop for other OSes). Addresses rdar://73887745 (cherry picked from commit 187f4db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to support parallel CI runs on the same Linux bot, so that
they don't share the module cache and reduce (hopefully) the likelihood
of issues related to invalid signatures.
When the option is enabled, the environment variable
XDG_CACHE_HOMEis explicitly set in
build-scriptand should be inherited by all thechild processes.
Currently we don't check the operating system before setting the
variable (since it should be a noop for other OSes).
Addresses rdar://73887745