Skip to content

Some Cleanup Of Overriding Diagnostics #35831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2021
Merged

Some Cleanup Of Overriding Diagnostics #35831

merged 4 commits into from
Feb 10, 2021

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Feb 8, 2021

  • Correct some mistakes in grammar and style noticed by @xwu
  • Introduce a fixit to write mistaken overrides of NSObject.hash(into:) as overrides of NSObject.hash

@CodaFi CodaFi requested a review from xwu February 8, 2021 20:18
@CodaFi
Copy link
Contributor Author

CodaFi commented Feb 8, 2021

@swift-ci smoke test

xwu
xwu approved these changes Feb 10, 2021
View reviewed changes
Copy link
Collaborator

@xwu xwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks for the gardening! Fix-it looks good.

@CodaFi
Copy link
Contributor Author

CodaFi commented Feb 10, 2021

⛵

@CodaFi CodaFi merged commit ddd1cd9 into swiftlang:main Feb 10, 2021
@CodaFi CodaFi deleted the extended-extracts branch February 10, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwu xwu xwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @xwu