Skip to content

Fix unchecked access to SPI decls from indirect clients #35886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

Fix unchecked access to SPI decls from indirect clients #35886

merged 1 commit into from
Feb 10, 2021

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Feb 10, 2021

Fix an issue where a public import (@_exported) broke the SPI checks in clients.

Future work may support for @_exported to export the SPIs too.

rdar://70502938

@xymus xymus requested a review from slavapestov February 10, 2021 20:36
@xymus
Copy link
Contributor Author

xymus commented Feb 10, 2021

@swift-ci Please smoke test

@xymus xymus merged commit a41fadb into swiftlang:main Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xymus