Skip to content

[CSBindings] A couple of minor refactorings #36008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2021
Merged

[CSBindings] A couple of minor refactorings #36008

merged 2 commits into from
Feb 17, 2021

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Feb 17, 2021 •
edited
Loading

  • Adjacent variables should track what constraint they have originated from so it easy to retract them later.
  • isLiteralCoveredBy belongs on LiteralRequirement instead of PotentialBindings.

@xedin
[CSBindings] Track source constraint of an adjacent variable
b3284c6 
This makes it much easier to remove adjacencies when constraint
is retracted from the bindings.
@xedin xedin requested a review from hborla February 17, 2021 00:41
@xedin xedin force-pushed the a-couple-of-binding-refactorings branch from 485009e to 655aeef Compare February 17, 2021 00:58
@xedin
Copy link
Contributor Author

xedin commented Feb 17, 2021

@swift-ci please smoke test

@xedin xedin merged commit d652ba0 into swiftlang:main Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @hborla