Skip to content

[android][test] Add REQUIRES: executable_test to simple_partial_apply_or_not #36019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

drodriguez
Copy link
Contributor

The test tries to execute the result of the compilation, so it needs to
be marked as executable to be able to be filtered out in platforms that
cannot execute the tests in CI (like Android).

Started happening in https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android/9290/ and https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/7716/ with the introduction of #36011.

…_or_not

The test tries to execute the result of the compilation, so it needs to
be marked as executable to be able to be filtered out in platforms that
cannot execute the tests in CI (like Android).
@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test and merge

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@swift-ci swift-ci merged commit 28855a5 into swiftlang:main Feb 17, 2021
@drodriguez drodriguez deleted the android-executable-partial-apply branch February 17, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants