Skip to content

[Frontend] Don't load modules from the prebuilt cache for private interfaces #36380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Mar 10, 2021

The compiler shouldn't use a swiftmodule file from the prebuilt cache when a private swiftinterface is present. The prebuilt cache only has the public interfaces of modules. Instead, when loading modules with a private interface the compiler should use swiftmodules from the local cache, the one next to the swiftinterface or rebuild it, in that order.

rdar://73007024

@xymus
Copy link
Contributor Author

xymus commented Mar 10, 2021

@swift-ci Please smoke test

@xymus xymus requested review from nkcsgexi and beccadax March 10, 2021 16:28
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@xymus xymus merged commit eeab067 into swiftlang:main Mar 10, 2021
@xymus xymus deleted the private-over-prebuilt branch March 10, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants