[Localization] Delay loading localization on startup #36705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HassanElDesouky
commented
Apr 1, 2021
xedin
reviewed
Apr 1, 2021
xedin
reviewed
Apr 5, 2021
HassanElDesouky
force-pushed
the
delay-loading-localization
branch
2 times, most recently
from
be18874 to
1dd38e9
Compare
HassanElDesouky
commented
May 12, 2021
HassanElDesouky
commented
May 12, 2021
HassanElDesouky
commented
May 12, 2021
HassanElDesouky
commented
May 12, 2021
xedin
requested changes
May 13, 2021
HassanElDesouky
commented
May 13, 2021
- Add `LocalizationProducerState` to manage the states of LocalizationProducers. - Add `initializeImpl` and `initializeIfNeeded` to manage lazily initialization of `LocalizationProducer`s. - Move constructing a localization producer from DiagEngine to `LocalizationProrducer` itself.
HassanElDesouky
force-pushed
the
delay-loading-localization
branch
from
c900057 to
481b29b
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were loading localization files on start-up, but now we need to stop loading them and instead load them when first diagnostic is requested, so there is no startup overhead for the compiler on projects without errors.
cc @xedin