[CodeCompletion][Parse] Don't drop the contained expression when completing within an InOutExpr #36738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leting within an InOutExpr When completing within an InOutExpr like `&foo.<complete>`, we were forming a CodeCompletionExpr with a base when parsing the content of the InOutExpr and storing it in CodeCompletionCallbacksImpl::CodeCompleteTokenExpr. When the result of that parse contained a code completion though, we were dropping the sub-expression completely and forming an empty code completion result in place of the inout expression, which resulted in later code inserting a code completion expression with no base into the AST. The solver based completion was later asking for the type of the code completion and its base using the expression stored in CodeCompletionCallbacksImpl::CodeCompleteTokenExpr, but that never ended up in the AST so we hit an assertion about the expression not have a type in the formed solutions. Resolves rdar://75366814
|
@swift-ci please test |
|
Build failed |
xedin
approved these changes
Apr 3, 2021
rintaro
approved these changes
Apr 5, 2021
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When completing within an
InOutExprlike&foo.<complete>, we were forming aCodeCompletionExprwith a base when parsing the content of theInOutExprand storing it inCodeCompletionCallbacksImpl::CodeCompleteTokenExpr. Whenever the result of that parse contained a code completion though, we were dropping it completely and returning an empty code completionParseResultin place of the inout expression, which resulted in later code inserting a differentCodeCompletionExprinto the AST that had no base expression. The solver-based completion implementation would later ask for the type of theCodeCompletionExprand its base using the expression stored inCodeCompletionCallbacksImpl::CodeCompleteTokenExpr, but that never actually ended up in the AST, resulting in an assertion hit about the expression not having a type in the formed solution(s).Resolves rdar://75366814