Add an option to recursive-lipo to explicitly specify files to be merged
#36960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain macOS Platform |
artemcm
force-pushed
the
RecursiveLipoException
branch
from
dfe411f to
29b60a3
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain macOS Platform |
1 similar comment
|
@swift-ci Please Build Toolchain macOS Platform |
…erged, even if contained in verbatim-copy directories, and use it for `libSwiftScan`. This library is contained in `lib/swift/<OS>/`, which `recursive-lipo` assumes contains the stdlib, and other Swift code built fat from the get-go. `libSwiftScan` is a part of the compiler build, and is therefore built for the host in a given build, which means toolchain installation requries that we use `lipo` to produce a fat shared library for it. Resolves rdar://74490218
artemcm
force-pushed
the
RecursiveLipoException
branch
from
29b60a3 to
792e3dd
Compare
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci Please Build Toolchain macOS Platform |
3 similar comments
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci Please Build Toolchain macOS Platform |
|
@swift-ci Please Build Toolchain macOS Platform |
edymtt
approved these changes
Apr 20, 2021
|
macOS Toolchain Install command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if contained in verbatim-copy directories, and use it for
libSwiftScan.This library is contained in
lib/swift/<OS>/, whichrecursive-lipoassumes contains the stdlib, and other Swift code built fat from the get-go.libSwiftScanis a part of the compiler build, and is therefore built for the host in a given build, which means toolchain installation requries that we uselipoto produce a fat shared library for it.Resolves rdar://74490218