[TypeChecker] Clear param specifiers before re-typechecking expression for completion #36992
Conversation
|
@swift-ci Please test |
| struct BottomMenu: MyView { | ||
| var body: some MyView { | ||
| let a = MyZStack(alignment: .#^COMPLETE^#center, content: {}) | ||
| .my_updating(body: { state in |
There was a problem hiding this comment.
So here is the interesting thing about this example - original type-check of this expression succeeds and produces a well-formed call. But then typeCheckForCodeCompletion called on type-checked AST and it seems not all of the information is erased. Why does that expression get re-typechecked that's probably where the investigation should start...
…n for completion Because we are completing inside a result builder, we are never calling into `typeCheckExpression` and thus never call into `typeCheckForCodeCompletion` before `fallbackTypeCheck` (SR-14601). This works fine in most cases, but in the added test case, we are hitting an assertion because the specifiers are not correctly erased from the `ClosureExpr` before re-typechecking for completion. Erasing them before fixes the test case until the underlying issue described above is fixed. Fixes rdar://76710904 [SR-14494]
ahoppen
changed the title
ahoppen
force-pushed
the
pr/wrapping-lvalue
branch
from
aebab69 to
b1a4708
Compare
|
@xedin Thanks for your feedback. I adjusted the PR to clear the specifiers of closure expression parameters, which fixes the test case in a more principled way. There seems to be a general issue with result builders that causes all expressions in there to be re-typechecked, because we are never calling into |
|
@swift-ci Please test |
Because we are completing inside a result builder, we are never calling into
typeCheckExpressionand thus never call intotypeCheckForCodeCompletionbeforefallbackTypeCheck(I filed SR-14601 to track that issue).This works fine in most cases, but in the added test case, we are hitting an assertion because the specifiers are not correctly erased from the
ClosureExprbefore re-typechecking for completion. Erasing them before fixes the test case until the underlying issue described above is fixed.Fixes rdar://76710904 [SR-14494]