[SR-13929][AutoDiff]: Enable [ossa] for all differentiation-generated thunks #37054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OrCreateSubsetParametersThunkForLinearMap
|
@swift-ci Please smoke test |
|
@swift-ci please smoke test linux |
…oDifferentiableFunction
|
@swift-ci Please test |
rxwei
approved these changes
Apr 26, 2021
| @@ -121,7 +121,7 @@ getOrCreateSubsetParametersThunkForLinearMap( | |||
| SILOptFunctionBuilder &fb, SILFunction *assocFn, | |||
| CanSILFunctionType origFnType, CanSILFunctionType linearMapType, | |||
| CanSILFunctionType targetType, AutoDiffDerivativeFunctionKind kind, | |||
| AutoDiffConfig desiredConfig, AutoDiffConfig actualConfig, | |||
| const AutoDiffConfig &desiredConfig, const AutoDiffConfig &actualConfig, | |||
There was a problem hiding this comment.
Nit: AutoDiffConfig is a 3-word trivial struct and we are currently passing it by value everywhere. For consistency it might be better to keep it as is and, if passing by reference is desirable, change it everywhere in a separate patch.
There was a problem hiding this comment.
... but given that all tests have passed, feel free to disregard this and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-differentiation mechanism in Swift creates a number of function reabstraction thunks. Most of them already use OSSA form but there is a couple of places that needs to be enabled.
The change enables SSA ownership for:
Resolves [SR-13929]: Enable ownership for all Differentiation-generated thunks.