Add locations from external modules to cursor info results #37145
Conversation
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
bnbarham
force-pushed
the
add-external-locs
branch
from
3715c9d to
14ca181
Compare
|
Added target triple to sourcekitd requests in the multi module test. @swift-ci please test |
|
I forgot to check the symbol graph result in the multi-module test. Adding that now but the comments aren't showing up - so this isn't ready to merge yet! |
.swiftsourceinfo contains comment ranges, so parsing should attach comments when it is being emitted. Generally this turned out to be fine because .swiftdoc is usually output as well, but when calling swift-frontend directly in tests that isn't necessarily the case.
.swiftsourceinfo files contain the serialized location for declarations. Use this when outputting locations in cursor info so that clients need not perform an extra index lookup for external modules.
Add line/column in addition to offset so clients need not map it themselves.
bnbarham
force-pushed
the
add-external-locs
branch
from
14ca181 to
0139fed
Compare
|
Build failed |
Have SourceKit return locations for symbols outside of the current module as well. Callsites of location and comment information should explicitly disable retrieving serialized information where performance is a concern. Resolves rdar://75582627
bnbarham
force-pushed
the
add-external-locs
branch
from
0139fed to
73d9f5b
Compare
|
Windows failure was \ vs /. @swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
Another spurious (but different) failure @swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
Use .swiftsourceinfo to include location information for results from external modules. Also add line and column so that clients don't need to map them from the offset.