[SymbolGraph] add sourceOrigin for synthesized symbols even if no docs exist #37248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://77205889
|
@swift-ci Please smoke test |
|
@swift-ci Please build toolchain macOS platform |
|
macOS Toolchain Install command |
franklinsch
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://77205889
When emitting
sourceOriginfields for synthesized symbols, the current implementation looks for decls that have docs. However, if the upstream symbol doesn't have docs to inherit, it currently skips adding thesourceOriginfield. This PR changes that behavior to always include the field for synthesized symbols, even if the upstream implementation doesn't have a doc comment to inherit.