Skip to content

[SwiftSyntax] Added helper for swift buildables #37426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented May 14, 2021

Share a helper method to define what type should be used

swiftlang/swift-syntax#284

@kimdv kimdv force-pushed the kimdv/add-helper-method-for-swift-syntax branch from ecf37ab to 0b1f0d0 Compare May 19, 2021 16:11
@ahoppen
Copy link
Member

ahoppen commented May 19, 2021

swiftlang/swift-syntax#284

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 0b1f0d05d67a2162498090fcb399287ca5aa7852

@kimdv kimdv force-pushed the kimdv/add-helper-method-for-swift-syntax branch 2 times, most recently from 770a19b to f57893c Compare May 19, 2021 20:21
@ahoppen ahoppen self-assigned this May 19, 2021
@ahoppen
Copy link
Member

ahoppen commented May 20, 2021

swiftlang/swift-syntax#284

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented May 20, 2021

Looks like CI was down earlier. Let’s try again.

swiftlang/swift-syntax#284

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - f57893c2444bd52b73f21349ec06ed42842438f2

@kimdv kimdv force-pushed the kimdv/add-helper-method-for-swift-syntax branch from f57893c to 0b0e20b Compare May 20, 2021 17:18
@kimdv
Copy link
Contributor Author

kimdv commented May 20, 2021

@ahoppen I'm nut sure why. But the linter didn't catch the missing new line at end and missing double space between the definitions.
Pushed and rebased. Sorry for that.

@ahoppen
Copy link
Member

ahoppen commented May 21, 2021

No worries @kimdv. Let’s try again.

swiftlang/swift-syntax#284

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 0b0e20b

@ahoppen
Copy link
Member

ahoppen commented May 21, 2021

Test failures are unrelated. Let’s try again.

swiftlang/swift-syntax#284

@swift-ci Please test Linux

@ahoppen
Copy link
Member

ahoppen commented May 21, 2021

swiftlang/swift-syntax#284

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Member

ahoppen commented May 22, 2021

swiftlang/swift-syntax#284

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 432f36e into swiftlang:main May 24, 2021
@kimdv kimdv deleted the kimdv/add-helper-method-for-swift-syntax branch May 24, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants