[5.5-05142021] Make sure we tail call optimize a call in concurrency runtime's switch_task_impl. #37485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… switch_task_impl. Without this hack the call will leave a stack frame around (not tail call optimized) and blow the stack if we call switch_task often enough. Ideally, clang would emit this call as `musttail` but currently it does not. rdar://76652421
Reverts hack from 9b4f7d6. rdar://76652421
|
@swift-ci please test |
|
Build failed |
DougGregor
approved these changes
May 18, 2021
|
5.5 PR: #37465 |
|
Build failed |
|
@swift-ci test |
|
Build failed |
|
Build failed |
airspeedswift
approved these changes
May 19, 2021
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
returnto a few tail calls and theswiftasyncccconvention attribute to facilitate tail call optimization.rdar://76652421