Skip to content

[RemoteMirror] Add NULL checks to Remote Mirror malloc calls. #37505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented May 19, 2021

These calls can fail when passed absurd sizes, which can happen when we try to read data that's corrupt or doesn't contain what we think it should. Fail gracefully instead of crashing.

rdar://78210820

These calls can fail when passed absurd sizes, which can happen when we try to read data that's corrupt or doesn't contain what we think it should. Fail gracefully instead of crashing.

rdar://78210820
@mikeash mikeash requested a review from tbkka May 19, 2021 17:38
@mikeash
Copy link
Contributor Author

mikeash commented May 19, 2021

@swift-ci please smoke test

@mikeash mikeash merged commit 09ccd46 into swiftlang:main May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant