[5.5][SourceKit] Allow same filename #37567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed twice and `-experimental-allow-module-with-compiler-errors` is passed
When compiling a module, we can’t have two files with the same filename because the filename is used to disambiguate private declarations during CodeGen. For SourceKit this is not an issue and we shouldn’t stop providing semantic functionality because of it. Fixes rdar://77618144
|
@swift-ci Please test |
akyrtzi
approved these changes
May 21, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling a module, we can’t have two files with the same filename because the filename is used to disambiguate private declarations during CodeGen. For SourceKit this is not an issue and we shouldn’t stop providing semantic functionality because of it.
This is a more targeted version of #37512 (merged into
main), ignoring just the same-filename-used-twice-error, whereas #37512 ignores all errors generated by the driver.Fixes rdar://77618144