[CodeCompletion] Don't check 'InvalidAsyncContext' for imported globals #37591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'InvalidAsyncContext' depends on the decl context. That may case "sticky" not-recommended If it's cached for a non-async context. To workaround this, stop checking 'InvalidAsyncContext' when collecting completion items for caching. Also consistently use the 'SourceFile' as the decl context to avoid decl context specific behavior. rdar://78315441
rintaro
commented
May 21, 2021
| @@ -77,7 +77,7 @@ func test5() { | |||
| // STMT_1-LABEL: Results for filterText: ret [ | |||
| // STMT_1-NEXT: return | |||
| // STMT_1-NEXT: retLocal | |||
| // STMT_1-NEXT: repeat | |||
| // STMT_1: repeat | |||
There was a problem hiding this comment.
This is because withTaskGroup(of:returning:body:) and withThrowingTaskGroup(of:returning:body:) are ranked above repeat. They used to be InvalidAsyncContext.
|
@swift-ci Please test |
benlangmuir
approved these changes
May 21, 2021
|
Build failed |
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidAsyncContextdepends on the decl context. That may case "sticky" not-recommended If it's cached for a non-async context.To workaround this, stop checking
InvalidAsyncContextwhen collecting completion items for caching. Also consistently use theSourceFileas the decl context to avoid decl context specific behavior.rdar://78315441