Windows CMake Cache organization (NFC) #37737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the duplicated `llvm-mt` from the toolchain distribution list.
Make a few more options more explicit and re-group a few options. This is merely for ease of human processing.
|
CC: @drodriguez |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Just FYI, this is not used in the CI builds, as far as I know. I do not see any reference in the Thanks for the cc, but I think this might only apply to Azure? |
|
The documentation uses these files IIRC; however, you do bring up a good point - I think that we may want to consider using the CMake cache for the CI builds. The next set of changes that I want to make would be much more complicated otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.