[TaskLocal] copyTo must initializeWithCopy the task local value #37988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
ktoso
force-pushed
the
wip-local-inherit-async-fix
branch
from
b4f5d56 to
608376c
Compare
|
@swift-ci please smoke test |
|
rdar://79528413 |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is might be the solution to both rdar://79528413 as well as https://forums.swift.org/t/swift-5-5-cant-get-task-local-value-in-async/49641
When we copy values to an unstructured task, we must also increase the refcount of it.
I need to check with folks if this is the right way to do it.
This may not be the only issue here, but I'll get back to this on monday to dig deeper.