SIL: Allow lowering Optional<T> against a nested type of an opaque result type [5.5] #38377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sult type Only the root archetype is a OpaqueTypeArchetypeType; the nested types are NestedArchetypeType. Use the correct predicate here. Also remove a dead check in tuple lowering; the isa<OpaqueTypeArchetypeType>() check is dominated by isTypeParameterOrOpaqueArchetype() which is always true if isa<OpaqueTypeArchetypeType>() is true anyway. Fixes rdar://problem/79597666.
|
@swift-ci Please test |
jckarter
approved these changes
Jul 13, 2021
|
Original: #38376 |
airspeedswift
approved these changes
Jul 13, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the root archetype is a OpaqueTypeArchetypeType; the nested types are
NestedArchetypeType. Use the correct predicate here.
Also remove a dead check in tuple lowering; the
isa<OpaqueTypeArchetypeType>()check is dominated by isTypeParameterOrOpaqueArchetype() which is always
true if
isa<OpaqueTypeArchetypeType>()is true anyway.Fixes rdar://problem/79597666.