Fix ownership rauw to not leave behind stale ownership fixup context #38864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ownership rauw uses a shared ownership fixup context to maintain state. When ownership rauw fails, due to some invalid condition, we leave behind stale data in this shared ownership fixup context. This stale context can indvertantly affect the next rauw on addresses. In addition to setting the ownership fixup context to nullptr, we should also clear it so that it's internal data structures are cleared.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ownership rauw uses a shared ownership fixup context to maintain state. When ownership rauw fails, due to some invalid condition, we leave behind stale data in this shared ownership fixup context.
This stale context can indvertantly affect the next rauw on addresses.
In addition to setting the ownership fixup context to nullptr, we should also clear it so that it's internal data structures are
cleared.