Skip to content

ModuleInterface: avoid omitting platform names when printing @available #38874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2021
Merged

ModuleInterface: avoid omitting platform names when printing @available #38874

merged 1 commit into from
Aug 13, 2021

Conversation

nkcsgexi
Copy link
Contributor

rdar://81903124

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

xymus
xymus approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Do you think this will end up also expanding implicit platforms like the extensions?

@nkcsgexi
Copy link
Contributor Author

Yeah, I think so. The expansion should follow the cases in bool inheritsAvailabilityFromPlatform(PlatformKind Child, PlatformKind Parent)

@nkcsgexi nkcsgexi merged commit d44d264 into swiftlang:main Aug 13, 2021
@airspeedswift airspeedswift mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xymus xymus xymus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkcsgexi @xymus