Skip to content

Fix borrow canonicalization bugs #38875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2021
Merged

Fix borrow canonicalization bugs #38875

merged 2 commits into from
Aug 16, 2021

Conversation

meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented Aug 13, 2021 •
edited
Loading

  • Clear internal data structures after canonicalizing function args
  • Handle nil BorrowedValue during canonicalization

@meg-gupta
Clear internal data structures after canonicalizing function args
87a7d22 
Subsequent calls for borrow canonicalization will see issues if not.
@meg-gupta meg-gupta requested review from atrick, gottesmm and nate-chandler and removed request for atrick August 13, 2021 18:24
@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta meg-gupta changed the title Clear internal data structures after canonicalizing function args Fix borrow canonicalization bugs Aug 13, 2021
@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta meg-gupta merged commit 5d6659c into swiftlang:main Aug 16, 2021
atrick
atrick reviewed Aug 17, 2021
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick left review comments

@gottesmm gottesmm Awaiting requested review from gottesmm

@nate-chandler nate-chandler Awaiting requested review from nate-chandler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meg-gupta @atrick