[5.5][SILGen] Fix a couple bugs with wrapped parameters in initializers. #39121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as default argument generator functions.
emit those auxiliary decls inside the function body brace statement. This generalizes the old code to work for parameters to any kind of function (e.g. initializers).
…ameters with external property wrappers. Otherwise, the code will attempt to forward the wrapped value type to a function that accepts the property wrapper type.
…kind to none when default arguments are not inherited.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test Windows platform |
airspeedswift
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #38854
This is important to take for 5.5 because it fixes a SILGen crash and bogus error messages.
Attempting to use wrapped parameters in initializers would lead to a SILGen crash or a bogus error message because the local auxiliary decls for wrapped parameters were never emitted. Fix this by recording local auxiliary decls when the parameter is emitted, and emit those auxiliary decls before the body statements in
StmtEmitter::visitBraceStmt.Resolves: rdar://81560448, SR-15033