[ConstraintSystem] Fix incorrect type-check of IUO pattern bindings #39142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patterns associated with `PatternBindingDecl`s have to be type-checked in pattern binding context. Not doing so might result in spurious errors.
… variable targets Instead of passing pattern directly, let's fetch it from the pattern binding and remove extra argument from `SolutionApplicationTarget::forUninitializedVar`.
hborla
approved these changes
Sep 2, 2021
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patterns associated with
PatternBindingDecls have to be type-checkedin pattern binding context. Not doing so might result in spurious errors.