Skip to content

Use the just-built Darwin libLTO.dylib in lit tests #39208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

kubamracek
Copy link
Contributor

Turns out that today, Darwin linker invocations from tests using -lto end up using the system compiler's LTO library. We need to be using the just-built one instead.

@kubamracek kubamracek requested a review from compnerd September 8, 2021 19:14
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek requested a review from gottesmm September 8, 2021 19:19
@swift-ci
Copy link
Contributor

swift-ci commented Sep 8, 2021

Build failed
Swift Test Linux Platform
Git Sha - b9e9ab6547bb99efcc8a76a0d598540f1de6d93b

@kubamracek
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I want to know how you figured this out ...

@kubamracek kubamracek merged commit a3c7d6c into swiftlang:main Sep 9, 2021
@kubamracek kubamracek deleted the lit-ltoflags branch September 9, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants