Concurrency: add Windows support to SWIFT_TASK_PRINTF_DEBUG
#39348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pthread_self` is not portable to all platforms. Introduce a `_swift_get_current_thread_id` to abstract over accessing the current thread ID. On Windows, the thread ID and thread handle are two separate entities, unlike POSIX threads which treats them the same.
|
@swift-ci please test |
|
CC: @ktoso @DougGregor |
|
This is a cherry-pick of #39348 to the 5.5 branch, though there were conflicts as there were changes that were applied out of order. |
|
@swift-ci test |
@compnerd is this known failure? |
|
@shahmishal - no, its not, I don't see that in the results though? |
|
@ktoso - its the missing include that causes problems - |
|
Oh I see, thank you for explaining! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_selfis not portable to all platforms. Introduce a_swift_get_current_thread_idto abstract over accessing the currentthread ID. On Windows, the thread ID and thread handle are two separate
entities, unlike POSIX threads which treats them the same.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.