Add empty parens to var-to-function renames #3947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @swift-ci please smoke test and merge. |
harlanhaskins
force-pushed
the
you-know-claremont-street
branch
from
e0ecd5e to
a99ca85
Compare
|
@swift-ci please smoke test and merge. |
|
It looks like the smoke test skipped building Swift entirely? |
|
I saw this flutter earlier too. Let's just do it again. @swift-ci Please smoke test Linux platform |
|
@swift-ci please smoke test Linux platform. |
1 similar comment
|
@swift-ci please smoke test Linux platform. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Sep 22, 2016
"!call" doesn't imply "variable", so the fix-it isn't always correct. This reverts commit a99ca85.
jrose-apple
added a commit
that referenced
this pull request
Sep 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This adds empty parens when a var is renamed to a function of no arguments.
Resolved bug number: (SR-1649)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.