[Distributed] fix missing _remote func entry in TBD #39499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-tbd-fix-distributed
branch
3 times, most recently
from
2e6ab1f to
4fd022a
Compare
ktoso
force-pushed
the
wip-tbd-fix-distributed
branch
from
4fd022a to
6834f61
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://82199717
This reliably reproduces the issue of:
<unknown>:0: error: symbol '$s4test20SomeDistributedActorC5hello4nameS2S_tFTd' (super test.SomeDistributedActor.hello(name: Swift.String) -> Swift.String) is in generated IR file, but not in TBD file<unknown>:0: error: symbol '$s4test20SomeDistributedActorC5hello4nameS2S_tFTdTu' (async function pointer to super test.SomeDistributedActor.hello(name: Swift.String) -> Swift.String) is in generated IR file, but not in TBD fileI can't really figure out how to emit those while I get a
$s4test20SomeDistributedActorC5hello4nameS2S_tFin the TBDGenVisitor, does it mean the contents it is visiting are missing theTdmethod descriptor...?