improve robustness of dist actor test #39910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing flaky runs due to the hard-to-determine order and point at which the actor instances were being deallocated in the old version of the test. In addition, all of the actor addresses were the same, so moving the point of deallocation would give us a less rigorous test. This patch puts all of the instances in an array so that we can rely on CHECK-DAG to check for the deallocations in any order, as a group at the end of the test. The deallocations are now identifiable using a simple counter for the addresses. resolves rdar://84574311
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing flaky runs due to the hard-to-determine order and point at which
the actor instances were being deallocated in the old version of the test. In addition,
all of the actor addresses were the same, so moving the point of deallocation would
give us a less rigorous test.
This patch puts all of the instances in an array so that we can rely on CHECK-DAG
to check for the deallocations in any order, as a group at the end of the test. The
deallocations are now identifiable using a simple counter for the addresses.
resolves rdar://84574311